Skip to content

Add more push server options#607

Draft
cameronvoell wants to merge 1 commit intomainfrom
cv/push-server-options
Draft

Add more push server options#607
cameronvoell wants to merge 1 commit intomainfrom
cv/push-server-options

Conversation

@cameronvoell
Copy link
Contributor

Introduction 📟

Purpose ℹ️

Scope 🔭

@claude
Copy link

claude bot commented Oct 27, 2025

Claude Code is working…

I'll analyze this and get back to you.

View job run

@macroscopeapp
Copy link

macroscopeapp bot commented Oct 27, 2025

Add push server options by introducing XMTPPush.DeliveryMechanism and updating XMTPPush.register(token:) to delegate to XMTPPush.register(deliveryMechanism:) in XMTPPush.swift

Introduce DeliveryMechanism with apns(deviceToken:), firebase(deviceToken:), and custom(token:); add XMTPPush.register(deliveryMechanism:) that validates pushServer, builds Notifications_V1_RegisterInstallationRequest, and calls client.registerInstallation(request:); update XMTPPush.register(token:) to wrap as APNS; add non-UIKit stub that fatalErrors; map mechanisms via DeliveryMechanism.toProtobuf().

📍Where to Start

Start with XMTPPush.register(deliveryMechanism:) in XMTPPush.swift.


📊 Macroscope summarized 9a0cf9f. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted. View details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant